rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r530037406
##########
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##########
@@ -272,6 +273,8 @@ public void testMetricsForNestedStructFields() throws
IOException {
assertCounts(6, 1L, 0L, metrics);
assertBounds(6, BinaryType.get(),
ByteBuffer.wrap("A".getBytes()), ByteBuffer.wrap("A".getBytes()),
metrics);
+ assertCounts(7, 1L, 0L, 1L, metrics);
+ assertBounds(7, DoubleType.get(), Double.NaN, Double.NaN, metrics);
Review comment:
So I guess this will continue to happen until we ignore NaN values and
keep track of the lower and upper bounds ourselves for Parquet and ORC?
This is fine for now, but I would want this to be correct eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
