rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529092873
##########
File path: core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java
##########
@@ -203,6 +208,11 @@ void checkDataFile(ContentFile<?> dataFile, FileContent
content) {
} else {
Assert.assertNull(dataFile.equalityFieldIds());
}
+ if (hasNaNCount) {
+ Assert.assertEquals("NaN", METRICS.nanValueCounts(),
dataFile.nanValueCounts());
+ } else {
+ Assert.assertNull("NaN", dataFile.nanValueCounts());
+ }
Review comment:
I think writing NaN counts in v1 will probably simplify the test updates
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
