yyanyy commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529993162
##########
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##########
@@ -272,6 +273,8 @@ public void testMetricsForNestedStructFields() throws
IOException {
assertCounts(6, 1L, 0L, metrics);
assertBounds(6, BinaryType.get(),
ByteBuffer.wrap("A".getBytes()), ByteBuffer.wrap("A".getBytes()),
metrics);
+ assertCounts(7, 1L, 0L, 1L, metrics);
+ assertBounds(7, DoubleType.get(), Double.NaN, Double.NaN, metrics);
Review comment:
This was because I added NaN as the only value in this column during the
creation of the record in `buildNestedTestRecord`, and currently this will
result in upper and lower bound being both NaN (similar behavior as in
[this](https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestMetrics.java#L354-L355)
test. I added this extra column in order to test NaN handling in metrics
modes, and change to this test was a side effect. Do you want me to remove the
bound check in this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
