rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529092686
##########
File path: core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java
##########
@@ -60,9 +61,10 @@
private static final PartitionData PARTITION = DataFiles.data(SPEC,
"category=cheesy/timestamp_hour=10/id_bucket=3");
private static final Metrics METRICS = new Metrics(
1587L,
- ImmutableMap.of(1, 15L, 2, 122L, 3, 4021L, 4, 9411L), // sizes
- ImmutableMap.of(1, 100L, 2, 100L, 3, 100L, 4, 100L), // value counts
- ImmutableMap.of(1, 0L, 2, 0L, 3, 0L, 4, 0L), // null value
counts
+ ImmutableMap.of(1, 15L, 2, 122L, 3, 4021L, 4, 9411L, 5, 15L), // sizes
+ ImmutableMap.of(1, 100L, 2, 100L, 3, 100L, 4, 100L, 5, 100L), // value
counts
+ ImmutableMap.of(1, 0L, 2, 0L, 3, 0L, 4, 0L, 5, 0L), // null value counts
+ ImmutableMap.of(5, 10L), // null value counts
Review comment:
Typo: `// NaN value counts`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
