rdblue commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2934230462
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeletesRowReader.java:
##########
@@ -60,8 +62,17 @@ class PositionDeletesRowReader extends
BaseRowReader<PositionDeletesScanTask>
Schema expectedSchema,
boolean caseSensitive,
boolean cacheDeleteFilesOnExecutors) {
+ this(table, table.io(), taskGroup, expectedSchema, caseSensitive,
cacheDeleteFilesOnExecutors);
+ }
- super(table, taskGroup, expectedSchema, caseSensitive,
cacheDeleteFilesOnExecutors);
+ PositionDeletesRowReader(
Review Comment:
Since these classes are not public, it would be nice to avoid adding new
constructors. I think the rationale is to avoid changes to tests that just add
a param coming from table. If so, I'd like to signal that here by making this
private or something. This probably applies to other classes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
