nastra commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2938724440
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeletesRowReader.java:
##########
@@ -60,8 +62,17 @@ class PositionDeletesRowReader extends
BaseRowReader<PositionDeletesScanTask>
Schema expectedSchema,
boolean caseSensitive,
boolean cacheDeleteFilesOnExecutors) {
+ this(table, table.io(), taskGroup, expectedSchema, caseSensitive,
cacheDeleteFilesOnExecutors);
+ }
- super(table, taskGroup, expectedSchema, caseSensitive,
cacheDeleteFilesOnExecutors);
+ PositionDeletesRowReader(
Review Comment:
I think we should probably just add the `FileIO` as parameter to the
existing constructor (instead of adding a new constructor) and update the few
test places to pass the new parameter in order to align with all the other
changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
