nastra commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2938779736


##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -77,7 +77,7 @@ public class SparkScanBuilder extends BaseSparkScanBuilder
   private final Long endSnapshotId;
   private Scan localScan;
 
-  SparkScanBuilder(SparkSession spark, Table table, CaseInsensitiveStringMap 
options) {
+  public SparkScanBuilder(SparkSession spark, Table table, 
CaseInsensitiveStringMap options) {

Review Comment:
   we can work around this by moving the test into the same package, but the 
reason I went for making this public initially is because the class itself is 
public but all constructors were package-private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to