nastra commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2938756776
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkPartitioningAwareScan.java:
##########
@@ -79,7 +79,15 @@ abstract class SparkPartitioningAwareScan<T extends
PartitionScanTask> extends S
Schema projection,
List<Expression> filters,
Supplier<ScanReport> scanReportSupplier) {
- super(spark, table, schema, readConf, projection, filters,
scanReportSupplier);
+ super(
+ spark,
+ table,
+ () -> null != scan ? scan.io() : table.io(),
Review Comment:
We used to pass an explicit `null` prior to #15240 in
https://github.com/apache/iceberg/commit/30232d3e727c17e522cae8ce5ae054512f048333#diff-0153e16705ef18774810e779609a845cdc42dbfd1bca7b01315af1af8fb29beaL470
but that isn't true anymore, so I'll remove the null check here. thanks for
spotting this. There are also a few other places that check whether the scan
can be null and I'll clean those up in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
