rdblue commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2934248162
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -116,16 +118,18 @@ abstract class SparkScan implements Scan,
SupportsReportStatistics {
SparkScan(
SparkSession spark,
Table table,
+ Supplier<FileIO> fileIO,
Review Comment:
I actually considered using `Supplier<FileIO>` for the API from scan. Now
that it's clear that we will create a supplier anyway, should we just update
the scan interface so that the caller doesn't need to wrap it?
The nice thing about that is that we don't rely on docs or runtime
exceptions (unless you call `get` too early). Returning a supplier signals to
the caller that they should find out when the `FileIO` is accessible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
