rdblue commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2934241044
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkPartitioningAwareScan.java:
##########
@@ -79,7 +79,15 @@ abstract class SparkPartitioningAwareScan<T extends
PartitionScanTask> extends S
Schema projection,
List<Expression> filters,
Supplier<ScanReport> scanReportSupplier) {
- super(spark, table, schema, readConf, projection, filters,
scanReportSupplier);
+ super(
+ spark,
+ table,
+ () -> null != scan ? scan.io() : table.io(),
Review Comment:
I see that scan could be null from the handling in the constructor, but I
find that strange. When would it be null in practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]