yyanyy commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r536309052
##########
File path:
core/src/main/java/org/apache/iceberg/GenericPartitionFieldSummary.java
##########
@@ -136,8 +144,10 @@ public Object get(int i) {
case 0:
return containsNull;
case 1:
- return lowerBound();
+ return containsNaN;
Review comment:
This is a good point, I forgot that primitive boolean will be default to
false which will impact correctness when we use this in evaluator. I'll make
this nullable. Thanks for pointing this out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
