rdblue commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r544727714
##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -199,6 +200,12 @@ default boolean hasDeletedFiles() {
*/
boolean containsNull();
+ /**
+ * Returns true if at least one data file in the manifest has a nan value
for the field.
+ * Null if this information doesn't exist.
+ */
+ Boolean containsNaN();
Review comment:
While we don't expect other implementations of this interface, it is a
fair point that we would accept other implementations in any method that uses
`ManifestFile` as an argument type. Adding the default would ensure
backward-compatiblity in case anyone has an alternative implementation, and is
really low cost. So I'd opt to add it. Thanks @holdenk!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
