yyanyy commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r544532186
##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -199,6 +200,12 @@ default boolean hasDeletedFiles() {
*/
boolean containsNull();
+ /**
+ * Returns true if at least one data file in the manifest has a nan value
for the field.
+ * Null if this information doesn't exist.
+ */
+ Boolean containsNaN();
Review comment:
I think once this change is released, this field will be populated by
default, and making it nullable is mostly for backward compatibility; also the
unassigned value for this field is null in both the [actual
implementation](https://github.com/apache/iceberg/pull/1872/files#diff-5ed34e844eaf59fe89785c86989ba8a467414fa112e5d266a26cd867b795bc8bR45)
and [test
implementation](https://github.com/apache/iceberg/pull/1872/files#diff-c9732959939317302e8738e19b1d831cef747b77d4c8bfa2fdab883fd087a68aR153),
so I think defaulting to null here might not help much?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
