rdblue commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r536928399



##########
File path: core/src/main/java/org/apache/iceberg/PartitionSummary.java
##########
@@ -73,14 +75,16 @@ private PartitionFieldStats(Type type) {
     }
 
     public PartitionFieldSummary toSummary() {
-      return new GenericPartitionFieldSummary(containsNull,
+      return new GenericPartitionFieldSummary(containsNull, containsNaN,

Review comment:
       Since this is a `boolean`, maybe we can change the constructor as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to