yyanyy commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r537796897
##########
File path:
core/src/main/java/org/apache/iceberg/GenericPartitionFieldSummary.java
##########
@@ -72,10 +73,11 @@ public GenericPartitionFieldSummary(Schema avroSchema) {
}
}
- public GenericPartitionFieldSummary(boolean containsNull, ByteBuffer
lowerBound,
+ public GenericPartitionFieldSummary(boolean containsNull, Boolean
containsNaN, ByteBuffer lowerBound,
Review comment:
This is for a [test
case](https://github.com/apache/iceberg/pull/1872/files#diff-366ef0b17670bc9547fe6d5b7b71a3d95c7f17eb97afa33c03dcdaeab27deb33R221)
that provide null here to test backward compatibility. I guess I'll mark this
constructor as `@VisibleForTesting` and create another public one that accepts
`boolean`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
