holdenk commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r544511435
##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -199,6 +200,12 @@ default boolean hasDeletedFiles() {
*/
boolean containsNull();
+ /**
+ * Returns true if at least one data file in the manifest has a nan value
for the field.
+ * Null if this information doesn't exist.
+ */
+ Boolean containsNaN();
Review comment:
Does it make sense for this to have a default of null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
