rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r600807180
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/DeleteRowReader.java
##########
@@ -31,13 +32,16 @@
import org.apache.spark.rdd.InputFileBlockHolder;
import org.apache.spark.sql.catalyst.InternalRow;
-public class EqualityDeleteRowReader extends RowDataReader {
+public class DeleteRowReader extends RowDataReader {
private final Schema expectedSchema;
+ private final FileContent deleteContent;
- public EqualityDeleteRowReader(CombinedScanTask task, Schema schema, Schema
expectedSchema, String nameMapping,
- FileIO io, EncryptionManager
encryptionManager, boolean caseSensitive) {
+ public DeleteRowReader(CombinedScanTask task, Schema schema, Schema
expectedSchema, String nameMapping,
+ FileIO io, EncryptionManager encryptionManager,
boolean caseSensitive,
+ FileContent deleteContent) {
Review comment:
There is no guarantee that the `CombinedScanTask` doesn't have both
position and equality deletes to apply, so it doesn't make sense to add this
argument and handle just one. I think that this reader should return all
deleted rows from a file, no matter which kind of delete was encoded. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
