rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r600812746
##########
File path: core/src/main/java/org/apache/iceberg/deletes/Deletes.java
##########
@@ -203,6 +206,10 @@ protected PositionFilterIterator(CloseableIterator<T>
items, CloseableIterator<L
@Override
protected boolean shouldKeep(T row) {
+ return keepDeleteRows != filter(row);
+ }
+
+ private boolean filter(T row) {
Review comment:
I think it would be better to have a subclass of this one that overrides
`shouldKeep` instead:
```java
class PositionStreamDeletedRowSelector extends PositionStreamDeleteFilter {
...
@Override
protected boolean shouldKeep(T row) {
return !super.shouldKeep(row);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
