rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r600809072
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/DeleteRowReader.java
##########
@@ -52,6 +56,10 @@ public EqualityDeleteRowReader(CombinedScanTask task, Schema
schema, Schema expe
// update the current file for Spark's filename() function
InputFileBlockHolder.set(file.path().toString(), task.start(),
task.length());
- return matches.findEqualityDeleteRows(open(task, requiredSchema,
idToConstant)).iterator();
+ if (deleteContent.equals(FileContent.EQUALITY_DELETES)) {
Review comment:
I think that this should use a combined `keepDeletedRows` method instead
of methods specific to equality or position deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
