rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r600813228
##########
File path: core/src/main/java/org/apache/iceberg/deletes/Deletes.java
##########
@@ -109,8 +109,9 @@ public static StructLikeSet
toEqualitySet(CloseableIterable<StructLike> eqDelete
public static <T> CloseableIterable<T> streamingFilter(CloseableIterable<T>
rows,
Function<T, Long>
rowToPosition,
-
CloseableIterable<Long> posDeletes) {
- return new PositionStreamDeleteFilter<>(rows, rowToPosition, posDeletes);
+
CloseableIterable<Long> posDeletes,
+ boolean
keepDeleteRows) {
Review comment:
I would rather not change this method. Instead, let's introduce a new
method to select deleted rows instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
