rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r603699094
##########
File path: core/src/main/java/org/apache/iceberg/deletes/Deletes.java
##########
@@ -158,7 +164,7 @@ protected boolean shouldKeep(T row) {
}
}
- private static class PositionStreamDeleteFilter<T> extends CloseableGroup
implements CloseableIterable<T> {
+ protected static class PositionStreamDeleteFilter<T> extends CloseableGroup
implements CloseableIterable<T> {
Review comment:
I think this can still be private because the subclass is also defined
in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
