rdblue commented on a change in pull request #2372:
URL: https://github.com/apache/iceberg/pull/2372#discussion_r603698874
##########
File path: core/src/main/java/org/apache/iceberg/deletes/Deletes.java
##########
@@ -191,7 +197,12 @@ private PositionStreamDeleteFilter(CloseableIterable<T>
rows, Function<T, Long>
return iter;
}
- private class PositionFilterIterator extends FilterIterator<T> {
+ protected FilterIterator<T> getPositionIterator(CloseableIterator<T> items,
+ CloseableIterator<Long>
newDeletePositions) {
+ return new PositionFilterIterator(items, newDeletePositions);
+ }
+
+ protected class PositionFilterIterator extends FilterIterator<T> {
Review comment:
Does this need to be protected? It looks like it could be private and
still used. Or, it could be protected and the `getPositionIterator` method
could be removed. I think I prefer the second option because it would require
no change to the `iterator` method in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
