openinx commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r735348367
##########
File path: flink/build.gradle
##########
@@ -18,6 +18,10 @@
*/
project(':iceberg-flink') {
+ project.ext {
+ flinkVersion = System.getProperty("flinkVersions") != null ?
System.getProperty("flinkVersions") : ""
Review comment:
Actually, I'm a little confused about the system properties
`flinkVersions` , `sparkVersions`, `hiveVersions`. Let's take the spark build
as an example: Currently, the candidate values for `sparkVersions` are
`2.4,3.0,3.2`. So when building the spark tests, it will add the
`build.gradle` from spark2.4 module, spark3.0 module and spark3.2 module. But
for the spark3.0 module, we will need to build the test against both spark3.0.x
and spark3.1.x. Then will we introduce another similar system property
`sparkBuild` like @jackye1995 proposed in
https://github.com/apache/iceberg/pull/3237 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
