openinx commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r735352913
##########
File path: flink/build.gradle
##########
@@ -18,6 +18,10 @@
*/
project(':iceberg-flink') {
+ project.ext {
+ flinkVersion = System.getProperty("flinkVersions") != null ?
System.getProperty("flinkVersions") : ""
Review comment:
I'm thinking why don't we assign a the specific engine version
`MAJOR.MINOR.BUGFIX` (rather than the `MAJRO.MINOR`version list) to the
`flinkVersion` (rather than the `flinkVersions`) to build all the version's
unit cases. In fact, in the
[flink-ci.yml](https://github.com/apache/iceberg/blob/master/.github/workflows/flink-ci.yml#L71),
the `-DflinkVersions=${{ matrix.flink }}` is also assigning one single value
to the `flinkVersions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
