kbendick commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r736107989
##########
File path: flink/build.gradle
##########
@@ -28,11 +32,11 @@ project(':iceberg-flink') {
implementation project(':iceberg-parquet')
implementation project(':iceberg-hive-metastore')
- compileOnly "org.apache.flink:flink-streaming-java_2.12"
- compileOnly "org.apache.flink:flink-streaming-java_2.12::tests"
- compileOnly "org.apache.flink:flink-table-api-java-bridge_2.12"
- compileOnly "org.apache.flink:flink-table-planner-blink_2.12"
- compileOnly "org.apache.flink:flink-table-planner_2.12"
+ compileOnly "org.apache.flink:flink-streaming-java_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-streaming-java_2.12:${flinkVersion}:tests"
+ compileOnly
"org.apache.flink:flink-table-api-java-bridge_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-table-planner-blink_2.12:${flinkVersion}"
+ compileOnly "org.apache.flink:flink-table-planner_2.12:${flinkVersion}"
Review comment:
I also think this would make sense, as there are certain interfaces in
1.13 that implement both the new and the old interface. But when the old
interface is implemented, it is preferred.
Specifically, for Flink, I am thinking of `FlinkCatalogFactory`. When
upgrading from 1.12 to 1.13, we had to implement the old 1.12 interface (the
interface as of 1.13 mixes in the "new" interface and maintains the deprecated
interface for compatibility reasons).
However, it doesn't allow users the ability to choose which path /
implementation they'd like to follow. So we had to make a choice to either
continue to support 1.12 or to not yet engage in the richer feature support
brought by later versions.
If we had modules split by at least major version (1.12, 1.13), then we
could implement these small but important difference differently for each
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
