rdblue commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r735734899
##########
File path: flink/build.gradle
##########
@@ -28,11 +32,11 @@ project(':iceberg-flink') {
implementation project(':iceberg-parquet')
implementation project(':iceberg-hive-metastore')
- compileOnly "org.apache.flink:flink-streaming-java_2.12"
- compileOnly "org.apache.flink:flink-streaming-java_2.12::tests"
- compileOnly "org.apache.flink:flink-table-api-java-bridge_2.12"
- compileOnly "org.apache.flink:flink-table-planner-blink_2.12"
- compileOnly "org.apache.flink:flink-table-planner_2.12"
+ compileOnly "org.apache.flink:flink-streaming-java_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-streaming-java_2.12:${flinkVersion}:tests"
+ compileOnly
"org.apache.flink:flink-table-api-java-bridge_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-table-planner-blink_2.12:${flinkVersion}"
+ compileOnly "org.apache.flink:flink-table-planner_2.12:${flinkVersion}"
Review comment:
The `flinkVersions` property is used only to determine which modules to
add to the build. We don't want to use it to set the Flink version because it
could be a list to add more than one set of Flink modules in the future.
If you want to use the `flinkVersions` property, then I think we should add
multiple Flink modules, for 1.12, 1.13, 1.14, etc. I'm not sure how we want to
manage those. For Spark, we are choosing to copy the code from one version to
the next so they are independent. That would make sense for Flink as well. And
because Flink only has 2 supported versions at a time, it wouldn't be that much
work to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
