openinx commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r736133217
##########
File path: flink/build.gradle
##########
@@ -28,11 +32,11 @@ project(':iceberg-flink') {
implementation project(':iceberg-parquet')
implementation project(':iceberg-hive-metastore')
- compileOnly "org.apache.flink:flink-streaming-java_2.12"
- compileOnly "org.apache.flink:flink-streaming-java_2.12::tests"
- compileOnly "org.apache.flink:flink-table-api-java-bridge_2.12"
- compileOnly "org.apache.flink:flink-table-planner-blink_2.12"
- compileOnly "org.apache.flink:flink-table-planner_2.12"
+ compileOnly "org.apache.flink:flink-streaming-java_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-streaming-java_2.12:${flinkVersion}:tests"
+ compileOnly
"org.apache.flink:flink-table-api-java-bridge_2.12:${flinkVersion}"
+ compileOnly
"org.apache.flink:flink-table-planner-blink_2.12:${flinkVersion}"
+ compileOnly "org.apache.flink:flink-table-planner_2.12:${flinkVersion}"
Review comment:
For different flink minor versions, I would recommend reusing existing
modules as much as possible, until a minor version we have to use copy code to
implement the development work based on subsequent flink new interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
