rdblue commented on a change in pull request #3364:
URL: https://github.com/apache/iceberg/pull/3364#discussion_r735730358
##########
File path: flink/build.gradle
##########
@@ -18,6 +18,10 @@
*/
project(':iceberg-flink') {
+ project.ext {
+ flinkVersion = System.getProperty("flinkVersions") != null ?
System.getProperty("flinkVersions") : ""
Review comment:
> when building the spark tests, it will add the build.gradle from
spark2.4 module, spark3.0 module and spark3.2 module. But for the spark3.0
module, we will need to build the test against both spark3.0.x and spark3.1.x
Not anymore. We're going to add a Spark 3.1 build to test directly rather
than reusing the same module for different versions.
> I'm thinking why don't we assign a the specific engine version
MAJOR.MINOR.BUGFIX (rather than the MAJRO.MINORversion list)
This is assuming that bugfix versions are compatible with one another, so we
only need one build for all of them. I really doubt that we want to test
against all patch/bugfix versions. That's way more effort to find problems in
the upstream project and not worth the time it would take in every Iceberg PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
