hameizi commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r744896728
##########
File path: core/src/main/java/org/apache/iceberg/ManifestWriter.java
##########
@@ -149,13 +150,17 @@ public long length() {
return writer.length();
}
+ void useSequenceNumber(long sequenceNumber) {
+ this.manifestSequenceNumber = sequenceNumber;
+ }
+
public ManifestFile toManifestFile() {
Preconditions.checkState(closed, "Cannot build ManifestFile, writer is not
closed");
// if the minSequenceNumber is null, then no manifests with a sequence
number have been written, so the min
// sequence number is the one that will be assigned when this is
committed. pass UNASSIGNED_SEQ to inherit it.
long minSeqNumber = minSequenceNumber != null ? minSequenceNumber :
UNASSIGNED_SEQ;
return new GenericManifestFile(file.location(), writer.length(), specId,
content(),
- UNASSIGNED_SEQ, minSeqNumber, snapshotId,
+ manifestSequenceNumber, minSeqNumber, snapshotId,
Review comment:
@rdblue I think @jackye1995 use the same idea as mine just because
iceberg apply eq-delete by manifestfile seqnumber, so it is easy to resolve
this problem by this way.
https://github.com/apache/iceberg/pull/3204#issuecomment-962701123
What you worry in this comment, I think the manifest file information has
snapshot id , and every snapshot has different seqnumber in metadata json file,
we can recover everything as we want. So can you give an example that you worry
about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
