jackye1995 commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r745859140
##########
File path: core/src/main/java/org/apache/iceberg/ManifestWriter.java
##########
@@ -149,13 +150,17 @@ public long length() {
return writer.length();
}
+ void useSequenceNumber(long sequenceNumber) {
+ this.manifestSequenceNumber = sequenceNumber;
+ }
+
public ManifestFile toManifestFile() {
Preconditions.checkState(closed, "Cannot build ManifestFile, writer is not
closed");
// if the minSequenceNumber is null, then no manifests with a sequence
number have been written, so the min
// sequence number is the one that will be assigned when this is
committed. pass UNASSIGNED_SEQ to inherit it.
long minSeqNumber = minSequenceNumber != null ? minSequenceNumber :
UNASSIGNED_SEQ;
return new GenericManifestFile(file.location(), writer.length(), specId,
content(),
- UNASSIGNED_SEQ, minSeqNumber, snapshotId,
+ manifestSequenceNumber, minSeqNumber, snapshotId,
Review comment:
> This PR should be updated so that the manifest list and manifest files
use a newly assigned sequence number and just the data file entries use the
specified sequence number.
Yes I think that is the approach used in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
