jackye1995 commented on a change in pull request #3480:
URL: https://github.com/apache/iceberg/pull/3480#discussion_r745311623
##########
File path: api/src/main/java/org/apache/iceberg/RewriteFiles.java
##########
@@ -73,4 +73,13 @@ RewriteFiles rewriteFiles(Set<DataFile> dataFilesToReplace,
Set<DeleteFile> dele
* @return this for method chaining
*/
RewriteFiles validateFromSnapshot(long snapshotId);
+
+ /**
+ * Use the specified sequence number for the new manifest of the data files
added in this update,
+ * instead of inheriting the sequence number of the snapshot that will be
created.
+ *
+ * @param sequenceNumber a sequence number
+ * @return this for method chaining
+ */
+ RewriteFiles overrideSequenceNumberForNewDataFiles(long sequenceNumber);
Review comment:
The reasons I used this long name are:
1. this is not actually committing with the given sequence number, the
overall sequence number still increments, but the sequence number provided is
used in the manifest entry of the newly added data files.
2. I was thinking maybe we will need to do something similar for delete
files, that's why there is a suffix of `ForNewDataFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
