jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r961968544
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -735,4 +786,29 @@ private Set<Tag> toTags(Map<String, String> properties,
String prefix) {
public Map<String, String> s3BucketToAccessPointMapping() {
return s3BucketToAccessPointMapping;
}
+
+ public <T extends S3ClientBuilder> void applyS3ServiceConfigurations(T
builder) {
+ builder
+ .dualstackEnabled(s3DualStackEnabled)
+ .serviceConfiguration(
+ S3Configuration.builder()
+ .pathStyleAccessEnabled(s3PathStyleAccess)
+ .useArnRegionEnabled(s3UseArnRegionEnabled)
+ .accelerateModeEnabled(s3AccelerationEnabled)
+ .build());
+ }
+
+ public SdkHttpClient.Builder configureHttpClientBuilder() {
Review Comment:
can we follow the same pattern as the method above, like `public <T extends
XXX> void configureHttpClientBuilder(T builder)` to set the HTTP client? XXX is
the common parent class of all AWS client builders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
