JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r962073201
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -735,4 +786,29 @@ private Set<Tag> toTags(Map<String, String> properties,
String prefix) {
public Map<String, String> s3BucketToAccessPointMapping() {
return s3BucketToAccessPointMapping;
}
+
+ public <T extends S3ClientBuilder> void applyS3ServiceConfigurations(T
builder) {
+ builder
+ .dualstackEnabled(s3DualStackEnabled)
+ .serviceConfiguration(
+ S3Configuration.builder()
+ .pathStyleAccessEnabled(s3PathStyleAccess)
+ .useArnRegionEnabled(s3UseArnRegionEnabled)
+ .accelerateModeEnabled(s3AccelerationEnabled)
+ .build());
+ }
+
+ public SdkHttpClient.Builder configureHttpClientBuilder() {
Review Comment:
I changed the method to this pattern by integrating the `.httpClientBuilder`
into this function. I also renamed it as `applyHttpClientConfiguration` since
now it will be used with `applyMutation` like the method above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
