JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r961836432
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -509,6 +538,26 @@ public AwsProperties(Map<String, String> properties) {
properties,
S3FILEIO_MULTIPART_UPLOAD_THREADS,
Runtime.getRuntime().availableProcessors());
+ this.s3PathStyleAccess =
+ PropertyUtil.propertyAsBoolean(
+ properties,
+ AwsProperties.S3FILEIO_PATH_STYLE_ACCESS,
+ AwsProperties.S3FILEIO_PATH_STYLE_ACCESS_DEFAULT);
+ this.s3UseArnRegionEnabled =
+ PropertyUtil.propertyAsBoolean(
+ properties,
+ AwsProperties.S3_USE_ARN_REGION_ENABLED,
Review Comment:
Ah, that's my mistake. I forgot to delete the `AwsProperties.` after
copy-pasting the code. Thank you for pointing it out.
I will also change other `AwsProperties.[FLAG_NAME]` to `[FLAG_NAME]` to
make the `AwsProperties` constructor cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
