[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256164#comment-16256164
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151568780
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -264,20 +264,27 @@ void
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo() {
if (!response_body.empty()) {
std::string controller = std::string(response_body.begin(),
response_body.end());
logger_->log_debug("controller config %s", controller.c_str());
- Json::Value value;
- Json::Reader reader;
- bool parsingSuccessful = reader.parse(controller, value);
- if (parsingSuccessful && !value.empty()) {
- Json::Value controllerValue = value["controller"];
- if (!controllerValue.empty()) {
- Json::Value port = controllerValue["remoteSiteListeningPort"];
- if (client_type_ == sitetosite::CLIENT_TYPE::RAW &&
!port.empty())
- this->site2site_port_ = port.asInt();
+
--- End diff --
If we're going to change the JSON code we should decouple it from this
class.
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
