[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256248#comment-16256248
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151580663
--- Diff:
libminifi/src/core/reporting/SiteToSiteProvenanceReportingTask.cpp ---
@@ -53,54 +56,92 @@ void SiteToSiteProvenanceReportingTask::initialize() {
RemoteProcessorGroupPort::initialize();
}
+void setJsonStr(const std::string& key, const std::string& value,
rapidjson::Value& parent, rapidjson::Document::AllocatorType& alloc) { // NOLINT
--- End diff --
It's just a shortcut wrapper for adding members from strings. I ran into a
lot of issues with strings being read as garbage. I'll move them to a central
location.
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
