[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256168#comment-16256168
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151569175
--- Diff: extensions/libarchive/FocusArchiveEntry.cpp ---
@@ -112,77 +109,45 @@ void
FocusArchiveEntry::onTrigger(core::ProcessContext *context, core::ProcessSe
if (targetEntryStashKey != "") {
session->restore(targetEntryStashKey, flowFile);
} else {
- logger_->log_warn("FocusArchiveEntry failed to locate target entry:
%s", targetEntry.c_str());
+ logger_->log_warn("FocusArchiveEntry failed to locate target entry:
%s",
+ archiveMetadata.focusedEntry.c_str());
}
// Set new/updated lens stack to attribute
{
- Json::Value lensStack;
- Json::Reader reader;
+ ArchiveStack archiveStack;
std::string existingLensStack;
if (flowFile->getAttribute("lens.archive.stack", existingLensStack)) {
logger_->log_info("FocusArchiveEntry loading existing lens context");
- if (!reader.parse(existingLensStack, lensStack)) {
- logger_->log_error("FocusArchiveEntry JSON parse error: %s",
reader.getFormattedErrorMessages());
+ try {
+ archiveStack.loadJsonString(existingLensStack);
--- End diff --
Same here. Is this something we want to rollback or transfer to failure?
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
