[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256261#comment-16256261
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151581577
--- Diff: extensions/http-curl/protocols/RESTReceiver.cpp ---
@@ -65,38 +65,8 @@ void RESTReceiver::initialize(const
std::shared_ptr<core::controller::Controller
}
}
int16_t RESTReceiver::heartbeat(const C2Payload &payload) {
- std::string operation_request_str = getOperation(payload);
--- End diff --
All of the tests passed, and I made sure the JSON payloads generated by the
exchanges were identical. But no, I haven't tested it in a production setting.
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
