[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256170#comment-16256170
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151569308
--- Diff: extensions/libarchive/FocusArchiveEntry.cpp ---
@@ -295,7 +260,9 @@ int64_t
FocusArchiveEntry::ReadCallback::process(std::shared_ptr<io::BaseStream>
return nlen;
}
-FocusArchiveEntry::ReadCallback::ReadCallback(core::Processor
*processor,fileutils::FileManager *file_man, ArchiveMetadata *archiveMetadata)
--- End diff --
Our line length is 200. We haven't merged your changes to lint the
extensions but you may want to limit these types of changes to reduce later
changes.
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
