[
https://issues.apache.org/jira/browse/MINIFICPP-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256173#comment-16256173
]
ASF GitHub Bot commented on MINIFICPP-114:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151569480
--- Diff: extensions/rocksdb-repos/CMakeLists.txt ---
@@ -23,7 +23,7 @@ cmake_minimum_required(VERSION 2.6)
set(CMAKE_EXE_LINKER_FLAGS "-Wl,--export-all-symbols")
set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--export-symbols")
-include_directories(../../libminifi/include ../../libminifi/include/core
../../thirdparty/spdlog-20170710/include ../../thirdparty/concurrentqueue
../../thirdparty/yaml-cpp-yaml-cpp-0.5.3/include
../../thirdparty/civetweb-1.9.1/include ../../thirdparty/jsoncpp/include
../../thirdparty/rocksdb/include ../../thirdparty/)
--- End diff --
thanks for catching this. We've all been copying and pasting these so at
some point we need to clean them up and I'm glad you caught this.
> Consolidate JSON API use to RapidJSON
> -------------------------------------
>
> Key: MINIFICPP-114
> URL: https://issues.apache.org/jira/browse/MINIFICPP-114
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: John Reynolds
> Assignee: John Reynolds
>
> MiNiFi was updated with new dependencies to jsoncpp:
> SiteToSiteProvenanceReportingTask
> Performance observations indicate significant improvements with RapidJSON vs.
> jsoncpp. Convert all use of jsoncpp to RapidJSON where applicable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
