dgrove-oss commented on a change in pull request #2991: controller creates
health and cacheInvalidation topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154222798
##########
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala
##########
@@ -46,15 +57,14 @@ object KafkaMessagingProvider extends MessagingProvider {
def getProducer(config: WhiskConfig, ec: ExecutionContext)(implicit logging:
Logging): MessageProducer =
new KafkaProducerConnector(config.kafkaHosts, ec)
- def ensureTopic(config: WhiskConfig, topic: String, topicConfig: Map[String,
String])(
- implicit logging: Logging): Boolean = {
+ def ensureTopic(config: WhiskConfig, topic: String, topicConfig:
String)(implicit logging: Logging): Boolean = {
Review comment:
I'm still using it to read kafka.replicationFactor. I think we should move
that value to kafka.conf as well, but I didn't want to delay getting this PR
merged to trace through all the deployment configs that might have set the
replicationFactor to different values for HA throughout the pipelines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
