dgrove-oss commented on a change in pull request #2991: controller creates
health and cacheInvalidation topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154940965
##########
File path: common/scala/src/main/resources/kafka.conf
##########
@@ -0,0 +1,24 @@
+kafka {
Review comment:
It struck me as more modular to have a conf files for the various
sub-components and include them in application.conf (similar to how logging is
already done). I don't have strong opinions on this, but we should decide what
we want to do and document it.
@markusthoemmes, is there some write up of conventions for how we should be
using pureconfig? One of my todos for the next couple of weeks is to migrate
as much as possible from ansible to pureconfig to reduce the number of build
breaks in kube. We had 4 separate kube build breaks last week due to variables
been added/updated in ansible configs and not replicated to the kube project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
