dgrove-oss commented on a change in pull request #2991: controller creates
health and cacheInvalidation topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154941730
##########
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala
##########
@@ -46,15 +57,14 @@ object KafkaMessagingProvider extends MessagingProvider {
def getProducer(config: WhiskConfig, ec: ExecutionContext)(implicit logging:
Logging): MessageProducer =
new KafkaProducerConnector(config.kafkaHosts, ec)
- def ensureTopic(config: WhiskConfig, topic: String, topicConfig: Map[String,
String])(
- implicit logging: Logging): Boolean = {
+ def ensureTopic(config: WhiskConfig, topic: String, topicConfig:
String)(implicit logging: Logging): Boolean = {
Review comment:
as above. Because @markusthoemmes was on vacation last week and I am not
clear on the plan for how values that are very likely to be changed in
different deployment need to be managed, I was leaving for followup PR. I'm
blocked on some other kube work (elimintating custom kafka image) until this PR
gets merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
