dgrove-oss commented on a change in pull request #2991: controller creates 
health and cacheInvalidation topics
URL: 
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154943232
 
 

 ##########
 File path: common/scala/src/main/resources/kafka.conf
 ##########
 @@ -0,0 +1,24 @@
+kafka {
 
 Review comment:
   ok.  So all the overrides still happen via environment variables (in ansible 
or yaml files for kube, etc).  So there is less value for a separate .conf file 
for different subsystems.  Should I merge kafka.conf into application.conf as 
suggested by @cbickel then?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to