dgrove-oss commented on a change in pull request #2991: controller creates health and cacheInvalidation topics URL: https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r154363650
########## File path: common/scala/src/main/scala/whisk/core/database/RemoteCacheInvalidation.scala ########## @@ -37,6 +37,7 @@ import whisk.core.entity.CacheKey import whisk.core.entity.InstanceId import whisk.core.entity.WhiskAction import whisk.core.entity.WhiskActionMetaData +import whisk.core.WhiskConfig Review comment: removed. I thought it was still needed because WhiskConfig is mentioned in the constructor down below, but I guess I don't understand Scala's import rules...only have to import if you actually do something with the type (not just passing it through?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
