dgrove-oss commented on a change in pull request #2991: controller creates
health and cacheInvalidation topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2991#discussion_r155249699
##########
File path: ansible/group_vars/all
##########
@@ -134,24 +134,8 @@ kafka:
ras:
port: 8093
heap: "{{ kafka_heap | default('1g') }}"
- replicationFactor: "{{ kafka_replicationFactor |
default((groups['kafkas']|length)|int) }}"
- topics:
- completed:
- segmentBytes: 536870912
- retentionBytes: "{{ kafka_topics_completed_retentionBytes |
default(1073741824) }}"
- retentionMS: "{{ kafka_topics_completed_retentionMS | default(3600000)
}}"
- health:
- segmentBytes: 536870912
- retentionBytes: "{{ kafka_topics_health_retentionBytes |
default(1073741824) }}"
- retentionMS: "{{ kafka_topics_health_retentionMS | default(3600000) }}"
- invoker:
- segmentBytes: 536870912
- retentionBytes: "{{ kafka_topics_invoker_retentionBytes |
default(1073741824) }}"
- retentionMS: "{{ kafka_topics_invoker_retentionMS | default(172800000)
}}"
- cacheInvalidation:
- segmentBytes: 536870912
- retentionBytes: "{{ kafka_topics_cacheInvalidation_retentionBytes |
default(1073741824) }}"
- retentionMS: "{{ kafka_topics_cacheInvalidation_retentionMS |
default(300000) }}"
+
+kafka_replicationFactor: "{{ (groups['kafkas']|length)|int }}"
Review comment:
I thought flattening was required if we wanted to use it via pureconfig.
Maybe I am still not understanding something here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services