sodonnel commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1923568142
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1522,7 +1549,6 @@ private void deleteInternal(Container container, boolean
force)
}
// Avoid holding write locks for disk operations
container.delete();
- sendICR(container);
Review Comment:
I am happy to move it there, but the `removeContainer` call also removes the
rocksDB entries, which could be slow if the disks are overloaded I guess.
Probably depends on how many blocks are in the container and how much data it
must read and remove from RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
