errose28 commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1927706185
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -322,6 +322,11 @@ public final class OzoneConfigKeys {
public static final String
OZONE_RECOVERING_CONTAINER_TIMEOUT_DEFAULT = "20m";
+ // Specifies how long a delete container command can wait on locks before
commencing the
+ // actual delete process. This is to avoid a delete command hanging for an
undetermined
+ // amount of time before SCM is informed the delete has been actioned.
+ public static final String OZONE_DELETE_CONTAINER_TIMEOUT =
"ozone.delete.container.timeout";
+ public static final String OZONE_DELETE_CONTAINER_TIMEOUT_DEFAULT = "1m";
Review Comment:
Yeah our config framework is a mess currently. Could certainly use an
internal overhaul. The more important part of my comment was to use the
`hdds.datanode` prefix to indicate it's scope instead of `ozone`. Latest commit
looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
