sodonnel commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1924994584


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1490,6 +1509,13 @@ private void deleteInternal(Container container, boolean 
force)
         // 4. container moved to tmp folder
         // 5. container content deleted from tmp folder
         try {
+          long waitTime = clock.millis() - startTime;
+          if (waitTime > maxDeleteLockWaitMs) {

Review Comment:
   We can consider that as an improvement if this doesn't work well. As it 
stands, we are not sure if the long running commands were due to lock waits or 
slow deletes. It seems most likely it was slow deletes, but the logs had all 
rolled off on the cluster before we got to them. For now I think it makes sense 
to keep this simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to