sodonnel commented on code in PR #7726:
URL: https://github.com/apache/ozone/pull/7726#discussion_r1924999115
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1521,8 +1547,8 @@ private void deleteInternal(Container container, boolean
force)
container.writeUnlock();
}
// Avoid holding write locks for disk operations
- container.delete();
sendICR(container);
+ container.delete();
Review Comment:
Even with the current code, the container is out of the container map, and
not able to be found by a subsequent delete operation. The original code would
fail to send the ICR and fail to process further deletes if the delete fails.
The container data will have been moved into the tmp folder before the ICR has
been sent and can be cleaned up by other means. Is there anything that cleans
this folder on startup to deal with failures on the current code path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
